Lift locales from extensions to top level
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to move ahead with merging this as part of the v2.1 draft, but if anyone has comments on this change, please add them here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you to @georgedonnelly for noticing that the
localesextension now creates validation errors following the stricter limits we placed onextensionsin v2!This PR pulls the
localesfield out ofextensionsto be a top-level registry property. There's a lot of benefit to be had in standardizing localization, and a top level field lets us 1) apply better validation by default, and 2) avoid needing to manipulate the expected shape of thelocalesobject to fit within the two-level restriction onextensions.