Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default value for named parameters, checks for parameter values, reporting for errors and fixed segmentation fault when object creation fails #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added default value for named parameters, checks for parameter values, reporting for errors and fixed segmentation fault when object creation fails #60

wants to merge 5 commits into from

Conversation

martinthomas
Copy link

No description provided.

@martinthomas
Added error handling and reporting for python module
b5fba14 
Added default values for named parameters so that we aren’t given
uninitialized junk.
Added simple parameter checking (capacity must be 1 or more,
error_range must be less than 1)
Added new exception type to be used when reporting errors
Added check for existing filter in dealloc.
@martinthomas
error_rate should be positive and less than 1
408768f
@martinthomas
Cleanup prior to pull request
b44a8b8
@ploxiln
Copy link
Contributor

ploxiln commented Jan 9, 2014

awesome stuff, thanks! we've been neglecting this for a while (and don't have a lot of experience with python c modules) so this is really appreciated.

We should get around to validating and merging this soon-ish, but also #35, which as you can see has languished for quite a while.

@martinthomas
Added parameter defauls and checking to load_dabloom
fbb5136 
Removed extraneous forward declaration.
Updated load_dabloom to have default values for named parameters.
Check values for sanity (no negative capacity etc).
@martinthomas
Copy link
Author

You are welcome. I will work on updating load_dabloom and check it passes
testing .. probably tonight.

On Thu, Jan 9, 2014 at 2:38 PM, Pierce Lopez [email protected]:

awesome stuff, thanks! we've been neglecting this for a while (and don't
have a lot of experience with python c modules) so this is really
appreciated.

We should get around to validating and merging this soon-ish, but also #35#35,
which as you can see has languished for quite a while.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-31973556
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinthomas @ploxiln