Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Incorporate Google refresh token into auth_token #120

Closed
wants to merge 3 commits into from

Conversation

mbland
Copy link
Contributor

@mbland mbland commented Jun 26, 2015

Required a change to Provider.ValidateToken() to return a new token if a refresh token was used.

@jehiah This is what I was thinking in my comments on #116. Still need to test it, and it looks like #117 is perhaps a more complete refactoring and renaming of things, but just wanted to put this on your radar.

Mike Bland added 3 commits June 26, 2015 12:24
Required a change to Provider.ValidateToken() to return a new token if a
refresh token was used.
Extraced common test server factory from myusa_test.go.
@mbland
Copy link
Contributor Author

mbland commented Jun 26, 2015

FWIW, added some tests, and tested successfully with a live running instance.

@jehiah
Copy link
Member

jehiah commented Jun 26, 2015

Thanks for the ping. I'll try to merge some of these tests into #117.

I'm inclined to land with that branch as i wrap up consolidating the session state which makes it easier to separate cookie refresh from token validation/refresh and to clean up the serialization and deserialization of a session from the cookie. That also gives way to more properly support token expiration separate from cookie expiration. I'll ping you there as i wrap that up in the next day or so.

@mbland
Copy link
Contributor Author

mbland commented Jun 26, 2015

Looks like #117 implements a far more robust solution. :-) Ha! Was just about to comment and close when yours popped up, @jehiah. Happy to take a look whenever you ping.

@mbland mbland closed this Jun 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants