This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
use Github provider with GitHub enterprise #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print the error stack trace point to my fork in oauthproxy.go addint pointers to ruta-goomba fork in mulitple files change api endpoint replace hard-coded github api endpoint with variables resetting fall through github urls to point to github.com fix malformed url changes to enable use with enterprise github
|
@ruta-goomba Thanks for this! Can you add a line to the readme under the Github section w/ a word about configuring for Github Enterprise? |
|
I added an ehancement to @ruta-goomba PR allowing the alternative api base url for github enteprise @ ruta-goomba#2. |
jehiah
added a commit
that referenced
this pull request
Feb 6, 2016
use Github provider with GitHub enterprise
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to resolve issue "Custom github url not supported #144"
I removed hard-coded github.com endpoints. With the proposed changes oauth2_proxy works with enterprise github if user sets validateURL (as well as loginURL and redeemURL) to github enterprise endpoint.