Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Add Cloudfoundry provider #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omazhary
Copy link

@omazhary omazhary commented Feb 9, 2016

this adds a provider for Cloudfoundry's UAA [1]

if you think this makes sense we can also add some unit tests.

The second commit allows to set X-Forwarded-User independent of HTTP Basic Auth as we need this for our Cloudfoundry/grafana scenario [2]

[1] https://github.com/cloudfoundry/uaa
[2] http://docs.grafana.org/installation/configuration/#authproxy

@omazhary
Copy link
Author

omazhary commented Jul 5, 2016

Running the test.sh script locally results in the following positive output:

ok      github.com/bitly/oauth2_proxy   0.042s
ok      github.com/bitly/oauth2_proxy/api   0.010s
ok      github.com/bitly/oauth2_proxy/cookie    0.011s
ok      github.com/bitly/oauth2_proxy/providers 0.018s
ok      github.com/bitly/oauth2_proxy   1.119s
ok      github.com/bitly/oauth2_proxy/api   1.027s
ok      github.com/bitly/oauth2_proxy/cookie    1.020s
ok      github.com/bitly/oauth2_proxy/providers 1.051s

However, the build fails. Am I running it wrong? @jehiah Is there perhaps something I'm missing?

@ploxiln
Copy link
Contributor

ploxiln commented Jul 5, 2016

Travis has the log of what failed which you can inspect. It's this:

2016/07/05 09:12:05 validator.go:42: failed opening authenticated-emails-file="/tmp/test_auth_emails_318131038", open /tmp/test_auth_emails_318131038: no such file or directory
FAIL    github.com/bitly/oauth2_proxy   0.130s

@omazhary
Copy link
Author

omazhary commented Jul 6, 2016

Yep @ploxiln, however, the error seems to be something that isn't related to my dev changes. I've rerun the tests locally, both on OSX and ubuntu, and they are successful every time. That's why I'm asking, am I doing something wrong, or is it a problem with the travis container in which the tests run?

@jsievers
Copy link

If this would make life easier for the committers I could open a new PR for this issue that removes the unrelated commit for issue #205 and squashes the remaining commits into one.
Let us know in case there is anything else you need to make this happen.

* Added a cloudfoundry provider (cloudfoundry.go) to interface with cloudfoundry's UAA [1]
* Provide defaults for local Cloudfoundry installation on BOSH lite [2]

[1] https://github.com/cloudfoundry/uaa
[2] https://github.com/cloudfoundry/bosh-lite
@jsievers
Copy link

I separated the cloudfoundry provider code from unrelated issue #205 (there will be a separate PR for that) Checks are passing, let me know if there is anything more we should add or fix here

@sks
Copy link

sks commented Jun 7, 2017

Is anyone ever going to look at this PR ?

@jmcarp
Copy link
Contributor

jmcarp commented Oct 7, 2017

Now that there's an OIDC provider, this might not be necessary, since the Cloud Foundry UAA speaks OIDC.

@jsievers
Copy link

jsievers commented Oct 9, 2017

yes I can confirm that oauth2_proxy works with Cloudfoundry UAA and the OIDC provider.
We can close this as obsolete

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

6 participants