This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Add option to set custom footer text #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe the CI test failures are due to my patch. Other PRs near the same time were giving the same error, and tests run fine on my machines. Please complain to me if I'm wrong about that. I'm using this patch in production with great success. |
|
@dustywilson fetch upstream and push again, I believe you (like me) were building with a recent version of golang which travis was not. Some upstream deps were no longer available for those ancient versions of golang. The travis build works now (see #249 ), so I suspect your build will pass once you rebase. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to resolve #166. Adds an option (in all the usual spots) called "footer" that allows for overriding the existing footer text. It's a static value. If you want the footer to go away altogether, just set it to " " (single space, not empty string). If it's set to empty string (default), it'll do the usual version/link footer. I expect that it's simple plaintext and any HTML would be escaped by the template.