Label "app.kubernetes.io/instance" in the condition_info Prometheus metric #1579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
A new label called
ss_app_kubernetes_io_instance
is added to the sealed_secrets_controller_condition_info Prometheus metricThis label shows the
app.kubernetes.io/instance
label value of the SealedSecret resource itself, if it existse.g
Here is an example of the newly added metric label:
I checked the
/metrics
endpoint and the metric label is considered empty if it did not exist, thus it is not breaking anythingBenefits
The scraped information of the Sealed Secret resources include an indicator of the instance name / release name associated to that specific resource
Users relying on Grafana may conduct more complex queries to join and map the instance name with other queries
Possible drawbacks
None
Applicable issues
None
Additional information
The usage of the
app.kubernetes.io/instance
label is the standard as it is part of the k8s recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/