Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label "app.kubernetes.io/instance" in the condition_info Prometheus metric #1579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tewfik-ghariani
Copy link
Contributor

@tewfik-ghariani tewfik-ghariani commented Aug 14, 2024

Description of the change

A new label called ss_app_kubernetes_io_instance is added to the sealed_secrets_controller_condition_info Prometheus metric

This label shows the app.kubernetes.io/instance label value of the SealedSecret resource itself, if it exists

e.g

apiVersion: bitnami.com/v1alpha1
kind: SealedSecret
metadata:
  labels:
    app.kubernetes.io/instance: grafana-qa

Here is an example of the newly added metric label:
Screenshot 2024-08-14 at 15 53 43

I checked the /metrics endpoint and the metric label is considered empty if it did not exist, thus it is not breaking anything

Benefits

The scraped information of the Sealed Secret resources include an indicator of the instance name / release name associated to that specific resource

Users relying on Grafana may conduct more complex queries to join and map the instance name with other queries

Possible drawbacks

None

Applicable issues

None

Additional information
The usage of the app.kubernetes.io/instance label is the standard as it is part of the k8s recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

@tewfik-ghariani
Copy link
Contributor Author

Hi, is it possible to review this PR? cc @agarcia-oss ^^

Copy link
Contributor

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the Stale label Sep 21, 2024
@tewfik-ghariani
Copy link
Contributor Author

not stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants