Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/harbor] Update ingress portal path to the last #15956

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[bitnami/harbor] Update ingress portal path to the last #15956

merged 2 commits into from
Apr 6, 2023

Conversation

cesarokuti
Copy link
Contributor

@cesarokuti cesarokuti commented Apr 4, 2023

Description of the change

Change ingress portal_path to the last path to support ingress ALB load balancer.
The problem is the same at issue at harbor official helm chart and fixed here.

Benefits

Can use harbor throught AWS ALB ingress controller

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the harbor label Apr 4, 2023
@github-actions github-actions bot added the triage Triage is needed label Apr 4, 2023
@ItaloChagas
Copy link

Nice one!

@javsalgar javsalgar added the verify Execute verification workflow for these changes label Apr 5, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Apr 5, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar April 5, 2023 08:24
Copy link
Contributor

@corico44 corico44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution.

@corico44 corico44 merged commit f1ab3df into bitnami:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harbor solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants