Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/common] Add the ability to specify namespaces for affinity #29396

Closed
wants to merge 0 commits into from

Conversation

klamas1
Copy link
Contributor

@klamas1 klamas1 commented Sep 13, 2024

Description of the change

Added the ability to specify namespaces for affinity

Benefits

You can create affinity and antiaffinity for workloads in different namespaces (I agree, this is a corner case, but still)

Possible drawbacks

None
By default, the behavior of templates does not change

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@klamas1
Copy link
Contributor Author

klamas1 commented Sep 17, 2024

It seems I broke everything and will have to create a new PR #29479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants