Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg support #59

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Pkg support #59

merged 2 commits into from
Feb 16, 2023

Conversation

enrico9034
Copy link
Contributor

In order to be able to release this tool as a single binary executable without having to install node and npm, for example, if you want to use it within a docker image, the pkg module asks to specify the assets you need, the only one that is not added automatically is config.json.

I already built the binary and tested it in a clean debian docker image and it runs fine.

Copy link
Contributor

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @enrico9034 for your contribution.

@fmulero fmulero merged commit e69f35d into bitnami:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants