Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified documentation #63

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

fherenius
Copy link

Description of the change

This MR clarified the README.md documentation on the # Parameters requirement. Where the documentation previously stated that a # Parameters section is required, it now states that the Parameters section should include at least two # or more symbols.

Change was made because lib/render.js:74 only looks for section titles with at least two ## symbols.

Benefits

I ran into the error that my # Parameters section could not be found due to this, so fixing this in the documentation hopefully prevents others from running into the same problem!

Checklist

  • Removed all checks, since none are relevant for a README.md change without any code changes.

…` specifically looks for `##` or more pound signs
Copy link
Contributor

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Fester and sorry about my very late response.

You are completely right. LGTM

@fmulero fmulero merged commit 055870a into bitnami:main Jul 31, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants