Add pre-commit hook #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 14, 2023 11:34
Signed-off-by: Yann Lacroix <[email protected]>
Signed-off-by: Yann Lacroix <[email protected]>
Signed-off-by: Yann Lacroix <[email protected]>
Signed-off-by: Yann Lacroix <[email protected]>
Signed-off-by: Yann Lacroix <[email protected]>
|
Hello there, any news on this PR ? @fmulero Would be nice to have it for this new year 💪🏼 |
|
I was looking for a pre-commit hook for this project and found this PR. My team started using @Brawdunoir 's implementation and it's been working great. I'm not a PR approver but I'm a +1 on merging this! |
fmulero
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Thanks a lot @Brawdunoir for your contribution!!! I really appreciate it!
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds a pre-commit hook instruction and its documentation. It allows pre-commit to run this soft automatically in any other project.
Applicable issues
Checklist