Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA-79 remove bucket acl #120

Merged
merged 3 commits into from
Apr 24, 2023
Merged

PSA-79 remove bucket acl #120

merged 3 commits into from
Apr 24, 2023

Conversation

mcascone
Copy link
Contributor

  • Remove bucket acl block in elb.tf
  • add changelog
  • bump copyright to 2023

@mcascone mcascone requested a review from LeoDiazL April 24, 2023 19:13
@mcascone mcascone self-assigned this Apr 24, 2023
LeoDiazL
LeoDiazL approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@LeoDiazL LeoDiazL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove the changelog and define a policy for Bitovi company-wide.
Once removed, merge away!

@mcascone mcascone merged commit a07065c into main Apr 24, 2023
@mcascone mcascone deleted the PSA-79-bucket-acl branch April 24, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoDiazL LeoDiazL LeoDiazL approved these changes

Assignees

@mcascone mcascone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcascone @LeoDiazL