Let assertEquals change into assertSame #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
commented
Nov 25, 2022
| @@ -53,122 +53,122 @@ public function testInputException() | |||
|
|
|||
| public function testCmpGreaterThan() | |||
| { | |||
| $expectedValue = '1'; | |||
| $expectedValue = 1; | |||
There was a problem hiding this comment.
The bccomp function will return the integer type to present compared result.
mwarzybok-sumoheavy
approved these changes
Jan 18, 2024
peter279k
force-pushed
the
improve_assertequals
branch
from
9d76687
to
c805010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
assertSameto replaceassertEqualsand make these assertions strict.