Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8BitAdamW and bitsandbytes.functional.create_dynamic_map #262

Closed
wants to merge 1 commit into from
Closed

8BitAdamW and bitsandbytes.functional.create_dynamic_map #262

wants to merge 1 commit into from

Conversation

ArrowM
Copy link

@ArrowM ArrowM commented Apr 7, 2023

Address Issue #227

Hello! 8BitAdamW has stopped working for Dreambooth since 0.36.0 (loss NaNs very quickly). I took a stab at reviewing the differences between the releases. The if-block around functional.py:218 in 2f2063b may have been accidentally indented. tests.test_functional.test_few_bit_quant doesn't cover the inside of the if block, so maybe this was missed (or it was intentional and it'd be great to have confirmation). I'm hoping one of the maintainers can take a quick look. Thanks!

@ArrowM ArrowM closed this Apr 7, 2023
@sdbds sdbds mentioned this pull request Jul 31, 2023
Closed
@KohakuBlueleaf KohakuBlueleaf mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArrowM