Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json format for test results + other enhancements #41

Merged
merged 12 commits into from
Sep 24, 2018

Conversation

johnsusek
Copy link
Contributor

This adds support for structured JSON test results that was just added to the master branch of elastalert.

Please see Yelp/elastalert#1897

When using the new option format=json, test results will look like this:

{
  "hits": 11,
  "terms": {
    "syslog_severity_code": 6,
    "service": "Vpxa",
    "tags": [],
    "syslog_severity": "informational",
    "@timestamp": "2018-09-10T18:16:23.461Z",
    "syslog_facility": "user-level",
    "host": "c5014-cesx121.ms",
    "@version": "1",
    "dept_id": "ms",
    "message": "- - [Originator@68762018-09-10T18:16:23.450Z Vpxa: verbose vpxa[FFC9AAE0] [Originator@6876[VpxaHalCnxHostagent::ProcessUpdate] Applying updates from 11843011 to 11843012 (at 11843011)",
    "syslog_pri": "14",
    "type": "syslog",
    "syslog_facility_code": 1
  },
  "name": "test321",
  "success": true,
  "days": 1
}

@johnsusek johnsusek changed the base branch from master to develop September 12, 2018 00:46
@martijnrondeel
Copy link
Contributor

Thank you for the PR! Is it ready to be merged or still WIP?

@johnsusek
Copy link
Contributor Author

Yes, it is ready to go!

@johnsusek johnsusek changed the title Add json format for test results. Add json format for test results + other enhancements Sep 18, 2018
@johnsusek
Copy link
Contributor Author

I've closed the other duplicate PRs. This is ready to be merged. Thank you :)

@johnsusek
Copy link
Contributor Author

@martijnrondeel Hi, any chance you could merge this when you have a moment? We are looking to release a test of our UI internally, that uses these changes. Yelp has already merged the needed changes into their latest code.

Here is a preview of the UI:
screen shot 2018-09-21 at 1 42 59 pm

https://github.com/ServerCentral/praeco

Thank you :)

@martijnrondeel
Copy link
Contributor

Thanks for your work! Going to merge this now and release a new version.

@bitsensor-bot bitsensor-bot merged commit 8e5011b into bitsensor:develop Sep 24, 2018
@martijnrondeel
Copy link
Contributor

It's available now in the latest release (0.0.13).

@johnsusek johnsusek deleted the json-results branch September 24, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants