Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential something-for-nothing fill bug #184

Closed
vikramrajkumar opened this issue Jan 18, 2017 · 5 comments
Closed

Potential something-for-nothing fill bug #184

vikramrajkumar opened this issue Jan 18, 2017 · 5 comments

Comments

@vikramrajkumar
Copy link
Contributor

vikramrajkumar commented Jan 18, 2017

From @theoreticalbts on February 29, 2016 15:31

This report from @svk31 on Slack:

something strange appears to have happened in the BTS:METAEX.BTC market: an order appears to have happened where someone paid 0 METAEX.BTC and received 1 satoshi BTS, making the price go to infinity or zero depending on your market direction

it's causing issues in the GUI when looking at that market

Possible duplicate of cryptonomex/graphene#555

Copied from original issue: cryptonomex/graphene#601

@vikramrajkumar
Copy link
Contributor Author

From @theoreticalbts on February 29, 2016 15:35

order_id in question is 1.7.104874

@vikramrajkumar
Copy link
Contributor Author

From @svk31 on March 8, 2016 8:22

We're getting a lot of these at the moment, would be great if this could get looked at sooner rather than later. As you can see from the below screenshot it causes the price to go to 0, and in the inverse market direction the charts fail due to Inf values..

image

@svk31
Copy link
Contributor

svk31 commented Mar 31, 2017

This just happened again in the BTS:USD market.

image

Full json of the order history object:

{"fee":{"amount":0,"asset_id":"1.3.0"},"order_id":"1.7.2764381","account_id":"1.2.6048","pays":{"amount":0,"asset_id":"1.3.121"},"receives":{"amount":586,"asset_id":"1.3.0"},"time":"2017-03-31T08:49:24"}

There's a logic in the witness_node called maybe_cull_small_orders, it seems to me that should've taken care of this order and cancelled it, but for some reason that's not working correctly.

takaaki7 added a commit to takaaki7/bitshares-core that referenced this issue Aug 2, 2017
@abitmore abitmore added this to the Future Consensus-Changing Release milestone Nov 27, 2017
@abitmore abitmore modified the milestones: Future Consensus-Changing Release, 201803 - Consensus Changing Release Feb 13, 2018
@abitmore abitmore self-assigned this Feb 14, 2018
@abitmore
Copy link
Member

As of writing, this issue has occurred 23524 times, and the number is still counting. Will address it in #641.

@abitmore
Copy link
Member

Done with #830. Closing.

@abitmore abitmore removed their assignment Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants