Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for BitShares Liquidity Pools (Poolmart) #3378

Merged
merged 80 commits into from
Jun 20, 2022

Conversation

AmmarYousefM
Copy link
Contributor

@AmmarYousefM AmmarYousefM commented Jul 9, 2021

The PR can be tested at: https://bts.exchange - please test and leave your feedback or comments below.

@sschiessl-bcp
Copy link
Contributor

Does it not bother you to do this in github ui? May I suggest to do a git tutorial to increase your productivity?

I am old school; just leave me alone :P

Old school would be using git

@AmmarYousefM
Copy link
Contributor Author

Does it not bother you to do this in github ui? May I suggest to do a git tutorial to increase your productivity?

I am old school; just leave me alone :P

Old school would be using git

git is very new to me; I used copy/paste, notepad++ and ancient ninja php programming methods :D

@sschiessl-bcp
Copy link
Contributor

Please start using it. Your way is costing you so much more time, let's be efficient.

@sschiessl-bcp
Copy link
Contributor

Let me do one holistic review including running this, then we see where we stand.

@sschiessl-bcp sschiessl-bcp merged commit 9e4d1d8 into bitshares:develop Jun 20, 2022
@sschiessl-bcp
Copy link
Contributor

I switched wording and removed the tabs that only had "Pools" tab. Maybe that can be a Spotlight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants