-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clock board i2c interface #443
Draft
hiddemoll
wants to merge
15
commits into
staging
Choose a base branch
from
add-clock-board-i2c-interface
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddemoll
force-pushed
the
add-clock-board-i2c-interface
branch
4 times, most recently
from
December 7, 2023 15:47
c5aa123
to
88e6fa3
Compare
lmbollen
force-pushed
the
add-clock-board-i2c-interface
branch
from
December 21, 2023 13:32
dae550d
to
f91e82a
Compare
hiddemoll
force-pushed
the
add-clock-board-i2c-interface
branch
from
February 1, 2024 09:21
f91e82a
to
8b45bcb
Compare
hiddemoll
force-pushed
the
add-clock-board-i2c-interface
branch
from
March 13, 2024 15:42
8b45bcb
to
9aa7d47
Compare
Previously you could not know from which address the wishbone bus was reading and could not stall acknowledgements.
hiddemoll
force-pushed
the
add-clock-board-i2c-interface
branch
from
April 23, 2024 11:45
9aa7d47
to
211183d
Compare
hiddemoll
force-pushed
the
add-clock-board-i2c-interface
branch
4 times, most recently
from
April 24, 2024 13:49
ddd9ede
to
eb5925a
Compare
This test should mirror FincFdecTests.hs but in software. Since HITL tests use a VIO, the current test is communicated to the CPU using a control register. The CPU communicates the status of the test back to the hardware using a status register, so it can be captured by the VIO. The frequency adjustments are slower over I2C compare to the dedicated pins on the external clock board (Si5395J-A-EVB). To speed up the test, the step size changed from 1ppb to 1ppm.
hiddemoll
force-pushed
the
add-clock-board-i2c-interface
branch
from
April 29, 2024 09:25
eb5925a
to
8560f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to program the clock chip on the FMC board.
We currently use the Skyworks Si5395J-A-EVB board as our external clock with frequecy adjustment. We also have a Trenz Electronic TEF0008 FMC, which we use for its 4 SFP ports. This board has a similar low jitter programmable clock generator (Si5345-D), but using this clock generator requires some changes.
The two major differences are programming the clock generator and the Finc and FDec signals. On the Skyworks board, we used SPI to program the clock generator, although it also could have been programmed using I2C. For the Finc and Fdec signals the dedicated pins were used, which worked using a pulse per Finc/Fdec.
On the Trenz FMC, we need to use I2C to program the clock generator. This board does not have dedicated pins for Finc/Fdec, and thus those signals also need to be send over I2C.
Issue #411
TODO
The current implementation does not work, as I2C transactions are not acknowledged (rust code reports
I2CError::NotAcknowledged
). Since the I2C core in clash-cores passes tests, there is probably a bug in the I2C Wishbone interface (i2cWb
). Debugging this problem is probably faster when the use GDB to program the Risc core (and for breakpoints).i2cWb
)probe_test_done
is not deasserted after first HITL test