Add support for configurable binding address #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaccioly
force-pushed
the
feature/configurable-binding-address
branch
from
a877755
to
e179ded
Compare
barrydeen
requested changes
Oct 19, 2024
|
|
||
| return Config{ | ||
| OwnerNpub: getEnv("OWNER_NPUB"), | ||
| DBEngine: getEnv("DB_ENGINE"), | ||
| DBEngine: getEnvString("DB_ENGINE", "lmdb"), |
There was a problem hiding this comment.
Why was this changed? It should default to badger
There was a problem hiding this comment.
It was already defaulting to LMDB when no env parameter was set. Look at line 57 above. I assumed you did this intentionally - wanting new installs to default to Badger, but not to touch old installs already using LMDB without specifying the env variable. If you'd prefer to switch even old installs to use Bager by default, feel free to change the string, or let me know and I can make the change myself.
There was a problem hiding this comment.
Ah yes you're right lol, thanks for knowing my relay better than me. Too many relays! Thanks for the pr
| @@ -48,8 +48,10 @@ func main() { | |||
|
|
|||
| http.HandleFunc("/", dynamicRelayHandler) | |||
|
|
|||
| log.Printf("🔗 listening at http://localhost:3355") | |||
| http.ListenAndServe("0.0.0.0:3355", nil) | |||
| addr := fmt.Sprintf("%s:%d", config.RelayBindAddress, config.RelayPort) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.