Consider Kubernetes API [] and null equivalent (#38)

See kubernetes/kubernetes#45294.
bitwalker · Jan 21, 2018 · 6d89805 · 6d89805
1 parent 654c226
commit 6d89805
Showing 1 changed file with 19 additions and 25 deletions.
diff --git a/lib/strategy/kubernetes.ex b/lib/strategy/kubernetes.ex
@@ -169,19 +169,16 @@ defmodule Cluster.Strategy.Kubernetes do
 
   defp parse_response(:ip, app_name, resp) do
     case resp do
-      %{"items" => []} ->
-        []
-      %{"items" => items} ->
+      %{"items" => items} when is_list(items) ->
         Enum.reduce(items, [], fn
-          %{"subsets" => []}, acc ->
-            acc
-          %{"subsets" => subsets}, acc ->
-            addrs = Enum.flat_map(subsets, fn
-              %{"addresses" => addresses} ->
-                Enum.map(addresses, fn %{"ip" => ip} -> :"#{app_name}@#{ip}" end)
-              _ ->
-                []
-            end)
+          %{"subsets" => subsets}, acc when is_list(subsets) ->
+            addrs =
+              Enum.flat_map(subsets, fn
+                %{"addresses" => addresses} when is_list(addresses) ->
+                  Enum.map(addresses, fn %{"ip" => ip} -> :"#{app_name}@#{ip}" end)
+                _ ->
+                  []
+              end)
             acc ++ addrs
           _, acc ->
             acc
@@ -193,20 +190,17 @@ defmodule Cluster.Strategy.Kubernetes do
 
   defp parse_response(:dns, app_name, resp) do
     case resp do
-      %{"items" => []} ->
-        []
-      %{"items" => items} ->
+      %{"items" => items} when is_list(items) ->
         Enum.reduce(items, [], fn
-          %{"subsets" => []}, acc ->
-            acc
-          %{"subsets" => subsets}, acc ->
-            addrs = Enum.flat_map(subsets, fn
-          %{"addresses" => addresses} ->
-            Enum.map(addresses, fn %{"ip" => ip, "targetRef" => %{"namespace" => namespace}} -> format_dns_record(app_name, ip, namespace) end)
-          _ ->
-            []
-        end)
-          acc ++ addrs
+          %{"subsets" => subsets}, acc when is_list(subsets) ->
+            addrs =
+              Enum.flat_map(subsets, fn
+                %{"addresses" => addresses} when is_list(addresses) ->
+                  Enum.map(addresses, fn %{"ip" => ip, "targetRef" => %{"namespace" => namespace}} -> format_dns_record(app_name, ip, namespace) end)
+                _ ->
+                  []
+              end)
+            acc ++ addrs
           _, acc ->
             acc
         end)