Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12071] - Validate domain has been verified #11125

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Sep 18, 2024

🎟️ Tracking

PM-12071

📔 Objective

In order to use the SSO provider, the domain must be verified. If not, we should have the user enter the Org Identifier. This fix will check if the domain is verified. This will be a temporary fix until a later refactor PM-12337.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.04%. Comparing base (0516ca0) to head (341470f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/auth/sso.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11125   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files        2711     2711           
  Lines       84576    84576           
  Branches    16068    16068           
=======================================
  Hits        29637    29637           
  Misses      53968    53968           
  Partials      971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Logo
Checkmarx One – Scan Summary & Detailscd72eb11-73c2-453e-96cd-0614695d1a76

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /libs/components/src/navigation/nav-divider.component.html: 1 Attack Vector
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 51 Attack Vector
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 51 Attack Vector

@jrmccannon jrmccannon changed the title Validate domain has been verified [PM-12071] - Validate domain has been verified Sep 18, 2024
@ike-kottlowski ike-kottlowski removed their request for review September 19, 2024 16:12
@jrmccannon jrmccannon merged commit 2b462b6 into main Sep 23, 2024
35 checks passed
@jrmccannon jrmccannon deleted the pm-12071-check-verified-date branch September 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants