[PM-12252] Autofill name of new ciphers #11127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11127 +/- ##
=======================================
Coverage 35.08% 35.08%
=======================================
Files 2709 2709
Lines 84531 84537 +6
Branches 16068 16067 -1
=======================================
+ Hits 29655 29663 +8
+ Misses 53905 53903 -2
Partials 971 971 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
There was a problem hiding this comment.
This looks good, but I do have a few questions before we merge:
- Should this be for all cipher types or just
Login? - If the extension is popped out, should we ignore the current tab? (This looks to be the case with the current extension)
cc: @danielleflinn
|
@shane-melton good catch on the type edge case, yes we should only add the default item name for Login item types. And yes, lets match the popout's behavior to what the existing extension does. |
|
Thanks, @shane-melton and @danielleflinn! Updated as such 01006d3 & 249c655 |
...wser/src/vault/popup/components/vault-v2/new-item-dropdown/new-item-dropdown-v2.component.ts
Show resolved
Hide resolved
| // pass along the uri and name | ||
| if (!poppedOut && type === CipherType.Login) { | ||
| loginDetails.uri = tab?.url; | ||
| loginDetails.name = Utils.getHostname(tab.url); |
There was a problem hiding this comment.
⛏️ tab?.url here as well. Or perhaps we check if the tab is null in the if condition?
Moving a little too quick for my own good 556ce26 |
🎟️ Tracking
PM-12252
📔 Objective
Autofill the
namewhen creating a new cipher on the extension refresh components📸 Screenshots
autofill-name.mov
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes