[PM-11503] Organization Automatic Sync verbiage is misleading #11151
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11151 +/- ##
==========================================
- Coverage 35.08% 35.04% -0.05%
==========================================
Files 2709 2711 +2
Lines 84530 84594 +64
Branches 16067 16074 +7
==========================================
- Hits 29661 29649 -12
- Misses 53898 53974 +76
Partials 971 971 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| "billingTokenSyncDesc": { | ||
| "message": "Billing sync unlocks Families sponsorships and automatic license syncing on your server. After making updates in the Bitwarden cloud server, select Sync License to apply changes." | ||
| }, |
There was a problem hiding this comment.
billingSyncDesc
apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html
Show resolved
Hide resolved
| @@ -90,7 +90,7 @@ <h2 class="mt-5"> | |||
| </a> | |||
| </bit-label> | |||
| <bit-hint> | |||
| {{ "billingSyncDesc" | i18n }} | |||
| {{ "automaticBillingSyncDesc" | i18n }} | |||
There was a problem hiding this comment.
automaticBillingSyncDesc is not defined in the en/messages.json
There was a problem hiding this comment.
automaticBillingSyncDesc has no changes over billingSyncDesc, maybe just revert this line and also the changes in en/messages.json where billingSyncDesc is removed.
| @@ -90,7 +90,7 @@ <h2 class="mt-5"> | |||
| </a> | |||
| </bit-label> | |||
| <bit-hint> | |||
| {{ "billingSyncDesc" | i18n }} | |||
| {{ "automaticBillingSyncDesc" | i18n }} | |||
There was a problem hiding this comment.
automaticBillingSyncDesc has no changes over billingSyncDesc, maybe just revert this line and also the changes in en/messages.json where billingSyncDesc is removed.
| "billingTokenSyncDesc": { | ||
| "message": "Billing sync unlocks Families sponsorships and automatic license syncing on your server. After making updates in the Bitwarden cloud server, select Sync License to apply changes." | ||
| }, |
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes