Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-446] Update hover state for unselected chip selects #11172

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Sep 20, 2024

🎟️ Tracking

CL-446

📔 Objective

This PR updates the hover state of the chip select for better visual contrast and to avoid issues with the hover color blending in with the extension background color.

📸 Screenshots

Screen.Recording.2024-09-23.at.4.35.04.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Logo
Checkmarx One – Scan Summary & Details2e8f77c4-50cc-47e9-8b18-339746dbfeda

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/attachments.component.ts: 35 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 484

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.19%. Comparing base (02eb6dc) to head (c8ece88).
Report is 1 commits behind head on ps/extension-refresh.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           ps/extension-refresh   #11172   +/-   ##
=====================================================
  Coverage                 35.19%   35.19%           
=====================================================
  Files                      2719     2719           
  Lines                     84996    84996           
  Branches                  16169    16169           
=====================================================
  Hits                      29911    29911           
  Misses                    54102    54102           
  Partials                    983      983           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 marked this pull request as ready for review September 23, 2024 20:35
@vleague2 vleague2 requested a review from a team as a code owner September 23, 2024 20:35
Copy link
Member

@danielleflinn danielleflinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ container color updated on hover for unselected chip
✅ text underline added on hover of unselected chip
✅ border color updated on hover of selected chip
✅ Figma library update + published with new styles for designers

@vleague2 vleague2 merged commit 95de2fe into ps/extension-refresh Sep 24, 2024
65 checks passed
@vleague2 vleague2 deleted the ds/cl-446/chip-select-hover branch September 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants