[PM-12281] [PM-12301] [PM-12306] Defects on Move Delete Item to Can Manage #11177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete button when a user does not have manage rights
|
No New Or Fixed Issues Found |
|
This PR addresses some defects that were introduced from this PR |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11177 +/- ##
==========================================
- Coverage 35.05% 34.98% -0.07%
==========================================
Files 2711 2711
Lines 84576 84562 -14
Branches 16069 16080 +11
==========================================
- Hits 29649 29585 -64
- Misses 53956 54006 +50
Partials 971 971 ☔ View full report in Codecov by Sentry. |
|
Closing this PR in favour of PM-12334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-12281
PM-12301
PM-12306
📔 Objective
Currently, users with Can Edit permissions can delete items within the collection. This should be updated so that only users with the Can Manage permission can delete items within a collection. This applies to the web client; a different PR would handle the other clients.
📸 Screenshots
Screen.Recording.2024-09-20.at.12.35.28.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes