Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to device-trust-logging feature flag #11183

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Sep 20, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12430

📔 Objective

Remove references to the feature flag in the clients and default to true.

See corresponding server PR: bitwarden/server#4795.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.97%. Comparing base (2b18185) to head (97849c1).
Report is 23 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11183      +/-   ##
==========================================
- Coverage   34.98%   34.97%   -0.02%     
==========================================
  Files        2712     2712              
  Lines       84576    84572       -4     
  Branches    16069    16068       -1     
==========================================
- Hits        29585    29575      -10     
- Misses      54020    54026       +6     
  Partials      971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details39640f11-8435-4289-af10-41c3214556e5

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_JQuery_Deprecated_Symbols /libs/importer/src/services/import.service.ts: 455 Attack Vector

@trmartin4 trmartin4 merged commit bdcf920 into main Sep 24, 2024
67 checks passed
@trmartin4 trmartin4 deleted the auth/pm-12430/remove-device-trust-logging-flag branch September 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants