-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVOPS-1733] - Add Feature Branch DB Migration Awareness #248
[DEVOPS-1733] - Add Feature Branch DB Migration Awareness #248
Conversation
New Issues
|
Since this action is used heavily, I would like us to come up with a non-invasive way to test these changes before merging in. Testing the changes should not send a message to the |
We have a workflow that runs and tests it when a PR is coming from this composite action file; I'm wondering why it's not running. I'm troubleshooting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a workflow that runs and tests it when a PR is coming from this composite action file;
Awesome! Can you add both success and failure test cases for the new db_migration_detected
input?
What happens if tag
is set to main|rc|hotfix-rc
?
I have only tested this action. To test the If the tag is set to any of |
I would like this PR to add success and failure test cases (essentially pipeline unit tests) to the
Adding these test cases allows us to test the |
Hey @joseph-flinn, could you check this now? |
Thanks for adding the tests, @Eeebru! |
🎟️ Tracking
🚧 Type of change
📔 Objective
📋 Code changes
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes