Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1752] - Pass Inputs in the Function #254

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Feb 16, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿšง Type of change

  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

  • Refactor

๐Ÿ“‹ Code changes

  • report-deployment-status-to-slack/action.yml: Update where input is being passed

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner February 16, 2024 10:10
@Eeebru Eeebru enabled auto-merge (squash) February 16, 2024 10:19
@Eeebru Eeebru merged commit 96e9904 into main Feb 16, 2024
3 of 4 checks passed
@Eeebru Eeebru deleted the DEVOPS-1752-inputs-in-function branch February 16, 2024 10:20
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 8b37565e-4f52-4c7e-947d-94cba6fabd53

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants