Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Updated" to "Deploy" #265

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mimartin12
Copy link
Contributor

@mimartin12 mimartin12 commented Mar 13, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿšง Type of change

  • ๐ŸŽ‚ Other

๐Ÿ“” Objective

Changes the messaging shown in alerts from "updating" or "updated" to "deploying" or "deployed" to fit the name of the action itself (deployment-status). This also should make the messages be more acceptable in the release channels to use this for production environments.

๐Ÿ“‹ Code changes

  • report-deployment-status-to-slack/action.yml: Change the use of language from "update" to "deploy"

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@mimartin12 mimartin12 requested a review from a team as a code owner March 13, 2024 22:07
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 9367d5c8-f52d-4616-9d47-866087fd4cb3

No New Or Fixed Issues Found

@mimartin12 mimartin12 merged commit 116cb2f into main Mar 14, 2024
4 checks passed
@mimartin12 mimartin12 deleted the actions/slack-deploy-status-update-language branch March 14, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants