Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Slack Failure message #315

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Refactor Slack Failure message #315

merged 2 commits into from
Sep 19, 2024

Conversation

urbinaalex17
Copy link
Contributor

@urbinaalex17 urbinaalex17 commented Sep 19, 2024

🎟️ Tracking

📔 Objective

Improve slack failure message

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@urbinaalex17 urbinaalex17 requested a review from a team as a code owner September 19, 2024 14:01
@urbinaalex17 urbinaalex17 self-assigned this Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsdb2b9ba5-651c-4059-a9a4-62ed91a9a61e

No New Or Fixed Issues Found

@urbinaalex17 urbinaalex17 merged commit 756f78a into main Sep 19, 2024
6 checks passed
@urbinaalex17 urbinaalex17 deleted the failure-messsage branch September 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants