Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-10524: Persist user's autofill and vault unlock setup progress in create account flow #944

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Sep 17, 2024

🎟️ Tracking

PM-10524

📔 Objective

Adds support for persisting the user's progress for setting up unlock methods and enabling autofill during the create account flow. This is used to bring them back to these screens after vault unlock if the app is restarted and if they choose to set up either of these things later.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (a91c7f6) to head (bc5e833).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   88.68%   88.69%           
=======================================
  Files         622      622           
  Lines       39357    39399   +42     
=======================================
+ Hits        34903    34943   +40     
- Misses       4454     4456    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details4e5865b6-3163-4408-a93b-b9d000f06161

No New Or Fixed Issues Found

@matt-livefront matt-livefront merged commit 67ee5d9 into main Sep 19, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-10524-create-account-setup-flow branch September 19, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants