[PM-12012] Remove region parsing from email URL #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
andrebispo5
requested review from
matt-livefront,
phil-livefront,
victor-livefront,
brant-livefront and
a team
as code owners
andrebispo5
changed the base branch from
main
to
pm-12012/save-region-registration
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 630 630
Lines 39647 39643 -4
=======================================
- Hits 35161 35159 -2
+ Misses 4486 4484 -2 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Sep 18, 2024
| @@ -169,7 +169,7 @@ public class AppProcessor { | |||
|
|
|||
| // Check for specific URL components that you need. | |||
| guard let params = components.queryItems, | |||
| let host = components.host else { | |||
| components.host != nil else { | |||
There was a problem hiding this comment.
🤔 Do we even need to check the host here?
There was a problem hiding this comment.
if it does not have a host, it should be a good reason not to continue 🤔
fedemkr
previously approved these changes
Sep 18, 2024
fedemkr
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Merge after #946
🎟️ Tracking
PM-12012
📔 Objective
Remove unused parsing of region based on the URL received during email verification.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes