[PM-11894] update password generator policy #948
Conversation
…to follow overridePasswordType
|
No New Or Fixed Issues Found |
| @@ -10,7 +10,7 @@ enum PolicyOptionType: String { | |||
| case capitalize | |||
|
|
|||
| /// A policy option for the default type of the password generator. | |||
| case defaultType | |||
| case overridePasswordType | |||
There was a problem hiding this comment.
⛏️ The documentation comment should probably be updated as well
| @@ -48,6 +48,9 @@ struct PasswordGenerationOptions: Codable, Equatable { | |||
|
|
|||
| /// The separator to put between words in the passphrase. | |||
| var wordSeparator: String? | |||
|
|
|||
| /// Whether the password type should be enforced or not | |||
| var overridePasswordType: Bool? | |||
There was a problem hiding this comment.
🤔 Why is this boolean optional? What does a nil value represent as different from a false value?
There was a problem hiding this comment.
should never be nil actually, removed the optional
There was a problem hiding this comment.
Actually, this is making the test_decode_empty on PasswordGenerationOptionsTests to fail.
I'm afraid it might throw an exception when calling the decodePasswordOptions and there is no overridePasswordType.
Not sure on what scenarios this is used
There was a problem hiding this comment.
This model is persisted to UserDefaults to maintain the user's options between app runs. The optional bool allows decoding to succeed even if it doesn't exist in the previously persisted model.
| } | ||
| // if the stringValue is NOT emptu or null, overridePasswordType should be true | ||
| options.overridePasswordType = !(policy[.overridePasswordType]?.stringValue?.isEmpty ?? true) |
There was a problem hiding this comment.
🤔 Maybe I'm misunderstanding the logic, but doesn't putting this here mean that the options.overridePasswordType != true on line 187 will always be true for the first policy?
There was a problem hiding this comment.
you are right I messed up here.
It would work for most of the scenario but would fail on some edge cases. Fixed it and changed tests in order to catch this.
…wiftformat changes on PolicyService
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 622 622
Lines 39374 39374
=======================================
Hits 34918 34918
Misses 4456 4456 ☔ View full report in Codecov by Sentry. |
aj-rosado
requested review from
phil-livefront,
victor-livefront,
brant-livefront and
a team
as code owners
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11894
📔 Objective
Renaming property
defaultValuetooverridePasswordTypeas it is the name used on the other clientsUpdating the behaviour so that it forces the user to use the
overridePasswordTypeon the password generator📸 Screenshots
Screen.Recording.2024-09-18.at.17.39.41.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes