Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-9754] Update Duo AuthUrl null error message to match other clients #954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PM-9754] Update Duo AuthUrl null error message to match other clients #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55e6664
[PM-9754] Update Duo AuthUrl null error message to match other clients
andrebispo5 Sep 18, 2024
124677d
Merge branch 'main' into pm-9754/duo-authurl-null
andrebispo5 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion BitwardenShared/UI/Auth/Login/TwoFactorAuth/TwoFactorAuthProcessor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,10 @@ extension TwoFactorAuthProcessor: DuoAuthenticationFlowDelegate {

guard let authURLValue = maybeAuthURL,
let authURL = URL(string: authURLValue) else {
state.toast = Toast(text: Localizations.duoUnsupported)
state.toast = Toast(
// swiftlint:disable:next line_length
text: Localizations.errorConnectingWithTheDuoServiceUseADifferentTwoStepLoginMethodOrContactDuoForAssistance
)
Comment on lines -380 to +383
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Can we add a test for this?
🤔 I see the localization string Localizations.duoUnsupported is not used anywhere else. Can we remove it from the localizations file?

return
}

Expand Down
1 change: 1 addition & 0 deletions BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,4 +979,5 @@
"SetUpLaterQuestion" = "Set up later?";
"YouCanFinishSetupUnlockAnytimeDescriptionLong" = "You can finish setup anytime in Account Security under Settings. You’ll use your master password to unlock until you set up another method.";
"Confirm" = "Confirm";
"ErrorConnectingWithTheDuoServiceUseADifferentTwoStepLoginMethodOrContactDuoForAssistance" = "Error connecting with the Duo service. Use a different two-step login method or contact Duo for assistance.";
"ThePreAuthUrlsCouldNotBeLoadedToStartTheAccountCreation" = "The Pre Auth Urls could not be loaded to start the account creation.";
Loading