Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12023] Enforce hmac when mac key is present #1041

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Sep 13, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/issues/PM-12023
(https://bitwarden.atlassian.net/issues/PM-4185)

📔 Objective

Prevent downgrading of encstring types to hmac-less by enforcing hmac when the symmetric key used has a mac key.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Logo
Checkmarx One – Scan Summary & Detailsd4a2b2f2-a67d-450e-bb2a-8711d2956279

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (d23ec73) to head (022b01f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1041      +/-   ##
==========================================
+ Coverage   58.18%   58.24%   +0.05%     
==========================================
  Files         197      197              
  Lines       13486    13504      +18     
==========================================
+ Hits         7847     7865      +18     
  Misses       5639     5639              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten requested a review from a team September 13, 2024 09:08
@quexten quexten marked this pull request as ready for review September 13, 2024 09:13
@quexten quexten requested a review from Hinton September 17, 2024 11:09
@quexten quexten merged commit c57e3a7 into main Sep 17, 2024
69 of 70 checks passed
@quexten quexten deleted the km/pm-12023/enforce-hmac-when-mac-key-is-present branch September 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants