-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12023] Enforce hmac when mac key is present #1041
Merged
quexten
merged 9 commits into
main
from
km/pm-12023/enforce-hmac-when-mac-key-is-present
Sep 17, 2024
Merged
[PM-12023] Enforce hmac when mac key is present #1041
quexten
merged 9 commits into
main
from
km/pm-12023/enforce-hmac-when-mac-key-is-present
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed symmetriccryptokey
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
+ Coverage 58.18% 58.24% +0.05%
==========================================
Files 197 197
Lines 13486 13504 +18
==========================================
+ Hits 7847 7865 +18
Misses 5639 5639 ☔ View full report in Codecov by Sentry. |
mzieniukbw
reviewed
Sep 13, 2024
Hinton
reviewed
Sep 16, 2024
Hinton
approved these changes
Sep 17, 2024
quexten
deleted the
km/pm-12023/enforce-hmac-when-mac-key-is-present
branch
September 17, 2024 11:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/issues/PM-12023
(https://bitwarden.atlassian.net/issues/PM-4185)
📔 Objective
Prevent downgrading of encstring types to hmac-less by enforcing hmac when the symmetric key used has a mac key.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes