Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11922] Handle apk key hash as origin #1042

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Sep 13, 2024

🎟️ Tracking

📔 Objective

Add support for the new Origin type in passkey-rs

Points to: bitwarden/passkey-rs#16

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Logo
Checkmarx One – Scan Summary & Details04e83ca8-d38c-4822-97c1-44d70a3e0eeb

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 41 Attack Vector
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 40 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 341 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 56 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /languages/java/example/Example.java: 46
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/example/Example.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 138
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 20
MEDIUM Privacy_Violation /languages/java/example/Example.java: 53
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 192
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 173
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 124
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 66
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 58
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 338
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 198
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 86
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 58.16%. Comparing base (c04b9a0) to head (d1394e2).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-fido/src/types.rs 0.00% 20 Missing ⚠️
crates/bitwarden-fido/src/client.rs 0.00% 6 Missing ⚠️
crates/bitwarden-uniffi/src/platform/fido2.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1042      +/-   ##
==========================================
- Coverage   58.18%   58.16%   -0.03%     
==========================================
  Files         197      197              
  Lines       13487    13523      +36     
==========================================
+ Hits         7847     7865      +18     
- Misses       5640     5658      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu marked this pull request as ready for review September 18, 2024 12:21
@coroiu coroiu merged commit 08859a3 into main Sep 18, 2024
76 of 78 checks passed
@coroiu coroiu deleted the PM-11922-handle-apk-key-hash-as-origin branch September 18, 2024 13:24
coroiu added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants