Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1425] Update Napi SDK #1045

Merged
merged 3 commits into from
Sep 19, 2024
Merged

[SM-1425] Update Napi SDK #1045

merged 3 commits into from
Sep 19, 2024

Conversation

coltonhurst
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1425

📔 Objective

Update the Napi SDK to include the SM updates.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Sep 13, 2024
@coltonhurst coltonhurst changed the title [SM-1425] Update Napi [SM-1425] Update Napi SDK Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Logo
Checkmarx One – Scan Summary & Details07c97b68-0b5b-4722-a3ed-82ffbfea8a84

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.16%. Comparing base (7641717) to head (2941176).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1045   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files         197      197           
  Lines       13523    13523           
=======================================
  Hits         7865     7865           
  Misses       5658     5658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coltonhurst coltonhurst requested review from Thomas-Avery, Hinton and a team September 13, 2024 21:06
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coltonhurst coltonhurst merged commit 2e506f7 into main Sep 19, 2024
78 of 80 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1425-napi branch September 19, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants