Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-330 - Update Rust crate workflows #1057

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR updates the Rust crates workflows to release from the main branch instead of rc or hotfix-rc. Linting suggestions were also applied. The build-cli-docker.yml workflow was updated because we no longer use the master branch.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Sep 17, 2024
@vgrassia vgrassia requested a review from a team as a code owner September 17, 2024 16:16
@vgrassia vgrassia enabled auto-merge (squash) September 17, 2024 16:16
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Logo
Checkmarx One – Scan Summary & Details597a944a-2533-4f50-82cd-0ad0fb59ef8b

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 43 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 56

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (fb2053d) to head (b5e842e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         197      197           
  Lines       13504    13504           
=======================================
  Hits         7865     7865           
  Misses       5639     5639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgrassia vgrassia merged commit 3de7906 into main Sep 17, 2024
68 of 69 checks passed
@vgrassia vgrassia deleted the bre-330_update-rust-crates-workflows branch September 17, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants