Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linting Issue #1064

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix Linting Issue #1064

merged 1 commit into from
Sep 18, 2024

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Sep 18, 2024

📔 Objective

Fix the failing linting CI introduced here.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst requested a review from a team as a code owner September 18, 2024 02:26
@coltonhurst coltonhurst self-assigned this Sep 18, 2024
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details015d5db8-1d3d-4665-8d0a-0a131a48e42b

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (1309527) to head (64f8ea7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         197      197           
  Lines       13504    13504           
=======================================
  Hits         7865     7865           
  Misses       5639     5639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coltonhurst coltonhurst merged commit 5eebbfd into main Sep 18, 2024
70 of 71 checks passed
@coltonhurst coltonhurst deleted the FixLinting branch September 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants