Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release NAPI Workflow - Remove NPM Publish input #1103

Closed
wants to merge 1 commit into from

Conversation

vgrassia
Copy link
Member

๐Ÿ“” Objective

This PR removes the npm_publish input as it's no longer used. The functionality for NPM publishing was moved to the Publish NAPI workflow.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Sep 30, 2024
@vgrassia vgrassia requested a review from a team as a code owner September 30, 2024 16:25
@vgrassia vgrassia enabled auto-merge (squash) September 30, 2024 16:26
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 47bb2346-082e-4422-b664-9e6717f6b233

No New Or Fixed Issues Found

@vgrassia vgrassia closed this Sep 30, 2024
@vgrassia vgrassia deleted the remove-npm-publish-input branch September 30, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant