update go version in SDK and example project #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 58.55% 58.55%
=======================================
Files 178 178
Lines 11405 11405
=======================================
Hits 6678 6678
Misses 4727 4727 ☔ View full report in Codecov by Sentry. |
tangowithfoxtrot
commented
Jun 3, 2024
| @@ -11,7 +11,7 @@ on: | |||
|
|
|||
| env: | |||
| GO111MODULE: on | |||
| GO_VERSION: "^1.18" | |||
| GO_VERSION: "^1.21" | |||
There was a problem hiding this comment.
The build and release workflows were already building with Go 1.22.3 prior to this change. This is merely updating the workflows to match the minimum Go versions supported in our module.
withinfocus
approved these changes
Jun 3, 2024
coltonhurst
approved these changes
Jun 3, 2024
vgrassia
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1288
📔 Objective
Follow-up of SM-1288 to update the Go version requirements in our wrapper and example project.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes