Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1338] Add the ability to edit unassigned secrets #906

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Conversation

Thomas-Avery
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1338

📔 Objective

With the introduction of individual secret permissions, it is possible for a machine account to have read, write permission on an unassigned secret.
Editing this unassigned secret should be supported by bws.
This removes the client side validation that restricted the edit of an unassigned secret.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this Jul 16, 2024
@Thomas-Avery Thomas-Avery requested a review from a team as a code owner July 16, 2024 21:48
@Thomas-Avery Thomas-Avery changed the title [SM-1338] Add the ability to update unassigned secrets [SM-1338] Add the ability to edit unassigned secrets Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Logo
Checkmarx One – Scan Summary & Details0ab5c007-abaa-4be4-95dd-a40c118c2e84

No New Or Fixed Issues Found

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.07%. Comparing base (27a71d8) to head (c520d91).

Files Patch % Lines
crates/bws/src/command/secret.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files         194      194           
  Lines       13194    13194           
=======================================
  Hits         7663     7663           
  Misses       5531     5531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dani-garcia
dani-garcia previously approved these changes Jul 17, 2024
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/bws/src/command/secret.rs Outdated Show resolved Hide resolved
mzieniukbw
mzieniukbw previously approved these changes Jul 17, 2024
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thomas-Avery Thomas-Avery dismissed stale reviews from mzieniukbw and dani-garcia via 70f7a17 July 17, 2024 16:09
@Thomas-Avery Thomas-Avery merged commit 5e5ddab into main Jul 19, 2024
104 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/sm-1338 branch July 19, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants