[SM-1174] Use state by default #913
Conversation
|
No New Or Fixed Issues Found |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -48,6 +52,36 @@ | |||
| serialized_state.encrypt_with_key(&access_token.encryption_key)?; | |||
| let state_string: String = encrypted_state.to_string(); | |||
|
|
|||
| std::fs::create_dir_all(state_file.parent().unwrap())?; | |||
Check failure
Code scanning / clippy
used unwrap() on an Option value Error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sm/sm-1096 #913 +/- ##
==============================================
- Coverage 57.93% 57.82% -0.11%
==============================================
Files 193 192 -1
Lines 13119 13137 +18
==============================================
- Hits 7600 7597 -3
- Misses 5519 5540 +21 ☔ View full report in Codecov by Sentry. |
| @@ -39,6 +39,7 @@ chrono = { version = ">=0.4.26, <0.5", features = [ | |||
| "std", | |||
| ], default-features = false } | |||
| coset = { version = "0.3.7", optional = true } | |||
| dirs = "5.0.1" | |||
There was a problem hiding this comment.
Hmm, not a huge fan of adding this dependency to the bitwarden-core crate. It also feels weird for a library to have side effects and write files without being prompted.
|
As discussed, for now will only add default state to bws. Will do this in a separate PR. |
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes