[SM-1275] Update AccessTokenLogin to LoginAccessToken for SM #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltonhurst
changed the title
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 58.45% 58.45%
=======================================
Files 194 194
Lines 13358 13358
=======================================
Hits 7808 7808
Misses 5550 5550 ☔ View full report in Codecov by Sentry. |
coltonhurst
changed the title
Hinton
approved these changes
Aug 15, 2024
coltonhurst
added a commit
that referenced
this pull request
Aug 20, 2024
## 🎟️ Tracking https://bitwarden.atlassian.net/browse/SM-1413 ## 📔 Objective ### The Issue Through the C FFI, we were running into concurrency issues with multiple Tokio runtimes. A draft PR showing the concurrency issue with instructions can be found [here](#955). ### The Fix This PR fixes this issue for `bitwarden-c` and `bitwarden-py`, by preserving the runtime. Thanks @dani-garcia for the fix and working together on this one! ### Extra This also refactors the `AccessTokenLogin` type as a follow up for testing purposes for Go as initiated by [this](#953) PR. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1275
📔 Objective
As requested internally, this updates
AccessTokenLogintoLoginAccessTokenfor all SM language bindings. This will break functionality for each binding on main until they are each updated (or unless they are already updated). We are reviewing all bindings now and updates for all are on deck. There are a total of ~8 bindings to verify and update for SM, so the only alternative is including all changes in one PR, which would be nice to avoid.@Hinton please let us know if there is anything we are missing with this PR, besides subsequent PR's to fix this for each binding. Is there anything else that should be updated?
Note: we should not merge this if we plan to release any bindings before the subsequent updates come through.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes