Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle deprecation #960

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix gradle deprecation #960

merged 1 commit into from
Aug 15, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Aug 15, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Build android is broken after the breaking changes introduced in #951. This PR follows the recommended changes and splits setup gradle into two steps.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner August 15, 2024 15:11
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f13758c9-8ce9-457a-b4a2-1c48c10d2556

No New Or Fixed Issues Found

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 58.45%. Comparing base (4be1e09) to head (b3e52d4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   58.45%   58.45%           
=======================================
  Files         194      194           
  Lines       13358    13358           
=======================================
  Hits         7808     7808           
  Misses       5550     5550           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Hinton Hinton merged commit 8e9e8f1 into main Aug 15, 2024
100 of 105 checks passed
@Hinton Hinton deleted the ps/fix-gradle branch August 15, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants