Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implied default NuGet configuration #3175

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Aug 10, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Removes the default NuGet package source config per renovatebot/renovate#20888 (comment) as we're having issues with Renovate not applying package lock updates with its changes, perhaps because of https://github.com/renovatebot/renovate/blob/2fd071cadf24e4c21a5255f25bc8b521f838d3ff/lib/manager/nuget/artifacts.ts#L73 and how it wants to use an alternative setup.

Code changes

  • NuGet.config: Removal with note as to why.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

bitwarden-bot commented Aug 10, 2023

Logo
Checkmarx One – Scan Summary & Detailsf9f7399a-9e30-40bf-860b-f66bbf822538

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Missing User Instruction /Dockerfile: 1 A user should be specified in the dockerfile, otherwise the image will run as root
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 5 When installing a package, its pin version should be defined
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 5 When installing a package, its pin version should be defined

Fixed Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Missing User Instruction /Dockerfile: 1 A user should be specified in the dockerfile, otherwise the image will run as root
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 5 When installing a package, its pin version should be defined
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 5 When installing a package, its pin version should be defined
MEDIUM Image Version Using 'latest' /Dockerfile: 1 When building images, always tag them with useful tags which codify version information, intended destination (prod or test, for instance), stabili...

@withinfocus withinfocus changed the title Remove 'api' from NuGet configuration Rename NuGet configuration Aug 10, 2023
@withinfocus withinfocus changed the title Rename NuGet configuration Remove implied default NuGet configuration Aug 10, 2023
@withinfocus withinfocus marked this pull request as ready for review August 10, 2023 17:58
@withinfocus withinfocus merged commit d325f1d into master Aug 10, 2023
43 checks passed
@withinfocus withinfocus deleted the nugetapiremoval branch August 10, 2023 18:23
@withinfocus withinfocus mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants