Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IdentityServer license #3552

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add IdentityServer license #3552

merged 1 commit into from
Dec 12, 2023

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Dec 12, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Adds the license issued to us from Duende for redistribution. Per:

https://docs.duendesoftware.com/identityserver/v6/fundamentals/license_key

we will load a default from our configuration and installations can override it if they desire.

Once this is in place the log warning "You do not have a valid license key for the Duende software." will no longer be emitted.

Code changes

  • src/Core/Settings/GlobalSettings.cs: License key string property with a default.
  • bitwarden_license/src/Sso/Utilities/ServiceCollectionExtensions.cs and src/Identity/Utilities/ServiceCollectionExtensions.cs: License usage.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@withinfocus withinfocus marked this pull request as ready for review December 12, 2023 17:09
@withinfocus withinfocus requested a review from a team as a code owner December 12, 2023 17:09
@withinfocus withinfocus merged commit 52cb253 into master Dec 12, 2023
43 of 44 checks passed
@withinfocus withinfocus deleted the identity-license branch December 12, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants