Support client version prerelease flag in context and LD targeting #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4994 +/- ##
=======================================
Coverage ? 42.52%
=======================================
Files ? 1391
Lines ? 64830
Branches ? 5951
=======================================
Hits ? 27572
Misses ? 36032
Partials ? 1226 ☔ View full report in Codecov by Sentry. |
trmartin4
previously approved these changes
Nov 7, 2024
|
New Issues
Fixed Issues
|
trmartin4
approved these changes
Nov 7, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
Nov 12, 2024
…4994) * Support client version prerelease flag in context and LD targeting * Use integer instead of Boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14607
📔 Objective
Loads the new
Is-Prereleaseclient header into context and makes it available to LaunchDarkly.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes