Use more optimized methods

bjornbouetsmith · Jun 8, 2024 · de88b01 · de88b01
1 parent 2963d29
commit de88b01
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/Source/ROOT.Zfs.Core/Helpers/ZPoolStatusParser.cs b/Source/ROOT.Zfs.Core/Helpers/ZPoolStatusParser.cs
@@ -161,7 +161,7 @@ private static VDev ParseVDev(string[] lines, ref int currentIndex)
                 {
                     break;
                 }
-            } while (trimmed.StartsWith("/") && currentIndex <= lines.Length);
+            } while (trimmed.StartsWith('/') && currentIndex <= lines.Length);
 
             return vdev;
         }

diff --git a/Source/ROOT.Zfs.Core/Properties.cs b/Source/ROOT.Zfs.Core/Properties.cs
@@ -53,7 +53,7 @@ public PropertyValue Set(SetPropertyArgs args)
             var getArgs = new GetPropertyArgs { PropertyTarget = args.PropertyTarget, Property = args.Property, Target = args.Target };
 
             // Should be safe - if not, then the set above would have failed - if we could not find a property to set
-            return Get(getArgs).First();
+            return Get(getArgs)[0];
         }
 
         /// <inheritdoc />

diff --git a/Source/ROOT.Zfs.Public/Data/Size.cs b/Source/ROOT.Zfs.Public/Data/Size.cs
@@ -123,11 +123,11 @@ public static Size FromSizeString(string sizeString)
                 return new Size();
             }
 
-            if (!sizeString.EndsWith("B")
-                && !sizeString.EndsWith("K")
-                && !sizeString.EndsWith("M")
-                && !sizeString.EndsWith("G")
-                && !sizeString.EndsWith("T"))
+            if (!sizeString.EndsWith('B')
+                && !sizeString.EndsWith('K')
+                && !sizeString.EndsWith('M')
+                && !sizeString.EndsWith('G')
+                && !sizeString.EndsWith('T'))
             {
                 throw new ArgumentException("size must be a string that ends in either B, K, M, G, T");
             }

diff --git a/Source/ROOT.Zfs.Tests/Helpers/SmartInfoParserTest.cs b/Source/ROOT.Zfs.Tests/Helpers/SmartInfoParserTest.cs
@@ -649,7 +649,7 @@ public void GarbledOrNotSupportedOutShouldNotThrowExceptios()
             var stdOut = @"Smart data not supported";
 
             var info = SmartInfoParser.ParseStdOut("/dev/sda", stdOut);
-            Assert.AreEqual(true, info.ParsingFailed);
+            Assert.IsTrue(info.ParsingFailed);
         }
 
         [TestMethod]
@@ -679,7 +679,7 @@ public void PartialOutputShouldNotThrowExceptions()
 === START OF READ SMART DATA SECTION ===
 SMART Attributes Data Structure revision number: 17";
             var info = SmartInfoParser.ParseStdOut("/dev/sda", stdOut);
-            Assert.AreEqual(true, info.ParsingFailed);
+            Assert.IsTrue(info.ParsingFailed);
         }
 
         [TestMethod]
@@ -709,7 +709,7 @@ public void PartialAndGarbledOutputShouldNotThrowExceptions()
 === START OF READ SMART DATA SECTION ===SMART overall-health self-assessment test result:PASSEDSMART Attributes Data Structure revision number: 17
 ";
             var info = SmartInfoParser.ParseStdOut("/dev/sda", stdOut);
-            Assert.AreEqual(true, info.ParsingFailed);
+            Assert.IsTrue(info.ParsingFailed);
         }
 
         [TestMethod]